Skip to content

fix(NavigationManager): Remove break to return all defaultEntryIds #57357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
provokateurin merged 1 commit into from
Jan 12, 2026
Merged

fix(NavigationManager): Remove break to return all defaultEntryIds #57357

provokateurin merged 1 commit into from
Jan 12, 2026

Conversation

@SimJoSt
Copy link
Member

@SimJoSt SimJoSt commented Jan 6, 2026

Summary

Remove break to return all defaultEntryIds in NavigationManager.
Otherwise, only the first entry id is returned, breaking loading the value for the "Global Default App" option

Before:
Screenshot 2026-01-06 at 02 30 46
After:
Screenshot 2026-01-06 at 02 30 54

Checklist

@SimJoSt
fix(NavigationManager): Remove break to return all defaultEntryIds
16d8cc0 
Otherwise only the first entry id is returned, breaking loading the value for the "Global Default App" option

Signed-off-by: Joda Stößer <[email protected]>
@SimJoSt SimJoSt added this to the Nextcloud 32.0.4 milestone Jan 6, 2026
@SimJoSt SimJoSt requested a review from a team as a code owner January 6, 2026 02:12
@SimJoSt SimJoSt added bug 3. to review Waiting for reviews labels Jan 6, 2026
@SimJoSt SimJoSt requested review from Altahrim, leftybournes, salmart-dev and yemkareems and removed request for a team January 6, 2026 02:12
@nextcloud-bot nextcloud-bot mentioned this pull request Jan 7, 2026
Merged
provokateurin
provokateurin approved these changes Jan 12, 2026
View reviewed changes
Copy link
Member

@provokateurin provokateurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, my bad 🙈

@provokateurin
Copy link
Member

provokateurin commented Jan 12, 2026

/backport to stable32

@provokateurin
Copy link
Member

provokateurin commented Jan 12, 2026

/backport to stable31

@provokateurin provokateurin mentioned this pull request Jan 12, 2026
Closed
@provokateurin
Copy link
Member

provokateurin commented Jan 12, 2026

@SimJoSt please fix the DCO (git commit --signoff --amend)

@SimJoSt
Copy link
Member Author

SimJoSt commented Jan 12, 2026

@provokateurin I thought I set it up correctly. Signed-off-by: plus my name and email is already in the commit.
Anything I have missed?
In the CI output, it tells me what it was expecting and what it got, but both are exactly the same: https://github.com/nextcloud/server/pull/57357/checks?check_run_id=60107134505
Maybe it's because of the two umlauts in my name ö and ß.
Should I just manually set it to passing?

@provokateurin provokateurin merged commit 258b306 into nextcloud:master Jan 12, 2026
369 of 379 checks passed
This was referenced Jan 12, 2026
Open
Open
@provokateurin
Copy link
Member

provokateurin commented Jan 12, 2026 •
edited
Loading

Oh yeah, it was probably that. I set it to manually pass.

@nextcloud-bot nextcloud-bot mentioned this pull request Jan 12, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@susnux susnux susnux approved these changes

@provokateurin provokateurin provokateurin approved these changes

@Altahrim Altahrim Awaiting requested review from Altahrim Altahrim is a code owner automatically assigned from nextcloud/server-backend

@salmart-dev salmart-dev Awaiting requested review from salmart-dev salmart-dev is a code owner automatically assigned from nextcloud/server-backend

@yemkareems yemkareems Awaiting requested review from yemkareems yemkareems is a code owner automatically assigned from nextcloud/server-backend

@leftybournes leftybournes Awaiting requested review from leftybournes leftybournes is a code owner automatically assigned from nextcloud/server-backend

Assignees

No one assigned

Labels

3. to review Waiting for reviews bug

Projects

None yet

Milestone

Nextcloud 32.0.4

Development

Successfully merging this pull request may close these issues.

[Bug]: "Global Default App" setting only loads first value from config

3 participants

@SimJoSt @provokateurin @susnux